Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WALL] Lubega / WALL-4120 / APIProvider memory leak console error #17140

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

[WALL] Lubega / WALL-4120 / APIProvider memory leak console error #17140

wants to merge 17 commits into from
+38 −13

Conversation

lubega-deriv
Copy link
Contributor

@lubega-deriv lubega-deriv commented Oct 10, 2024 •
edited
Loading

Changes:

  • Add isMounted to APIProvider, WalletsAddMoreCarousel and useRemoteConfig to resolve various sources of memory leak console error
  • Add env variable for remote config url in appstore

Before:

  1. image
  2. image
  3. Bildschirmfoto 2024-10-22 um 10 07 31 AM
  4. Bildschirmfoto 2024-10-22 um 11 44 23 AM

After:

image
Bildschirmaufnahme.2024-10-22.um.1.37.45.PM.mov

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 15, 2024 3:29am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17140](https://github.com/deriv-com/deriv-app/pull/17140)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-remote-config-url-console-error.binary.sx?qa_server=red.derivws.com&app_id=24089
    - **Original**: https://deriv-app-git-fork-lubega-deriv-remote-config-url-console-error.binary.sx
- **App ID**: `24089`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-remote-config-url-console-error.binary.sx/

@coveralls
Copy link

coveralls commented Oct 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11849517184

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 19 (0.0%) changed or added relevant lines in 4 files are covered.
  • 917 unchanged lines in 109 files lost coverage.
  • Overall coverage decreased (-1.5%) to 53.139%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/api-v2/src/APIProvider.tsx 0 3 0.0%
packages/hooks/src/useGrowthbookGetFeatureValue.ts 0 4 0.0%
packages/wallets/src/components/WalletsAddMoreCarousel/WalletsAddMoreCarousel.tsx 0 5 0.0%
packages/api/src/hooks/useRemoteConfig.ts 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
packages/account/src/Configs/get-mt5-status-badge-config.tsx 1 0.0%
packages/account/src/index.tsx 1 0.0%
packages/account/src/Sections/Profile/PersonalDetails/verify-button.tsx 1 95.38%
packages/api/src/hooks/useRemoteConfig.ts 1 0.0%
packages/appstore/src/stores/index.ts 1 0.0%
packages/bot-web-ui/src/pages/bot-builder/quick-strategy/inputs/qs-input-label.tsx 1 71.43%
packages/bot-web-ui/src/pages/bot-builder/quick-strategy/selects/symbol.tsx 1 97.26%
packages/bot-web-ui/src/stores/quick-strategy-store.ts 1 86.9%
packages/indicators/src/indicators/relative-strength-index.js 1 97.44%
packages/p2p/src/components/modal-manager/modals/share-my-ads-modal/share-my-ads-modal.tsx 1 85.45%
Totals Coverage Status
Change from base Build 11776393709: -1.5%
Covered Lines: 32697
Relevant Lines: 57384
💛 - Coveralls

@lubega-deriv lubega-deriv force-pushed the remote-config-url-console-error branch from c8f8f99 to a37ce29 Compare October 22, 2024 02:33
@lubega-deriv lubega-deriv changed the title [WALL] Lubega / Remote config url console error [WALL] Lubega / WALL-4120 / APIProvider memory leak console error Oct 22, 2024
@lubega-deriv lubega-deriv marked this pull request as ready for review October 22, 2024 02:36
heorhi-deriv
heorhi-deriv previously approved these changes Oct 23, 2024
View reviewed changes
jim-deriv
jim-deriv previously approved these changes Nov 4, 2024
View reviewed changes
heorhi-deriv
heorhi-deriv previously approved these changes Nov 4, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-deriv jim-deriv jim-deriv left review comments

@heorhi-deriv heorhi-deriv heorhi-deriv left review comments

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@amina-deriv amina-deriv Awaiting requested review from amina-deriv amina-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@habib-deriv habib-deriv Awaiting requested review from habib-deriv habib-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv sandeep-deriv is a code owner

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lubega-deriv @coveralls @jim-deriv @heorhi-deriv